Using fast_float to do local independent parsing #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Jan.
I have asked Lukas Hejl from Prusa3D to do the code review.
Vojtech
…On Fri, Nov 3, 2023 at 2:08 PM Jan Orend ***@***.***> wrote:
@3dJan <https://github.com/3dJan> requested your review on: #325
<#325> Using fast_float to do
local independent parsing.
—
Reply to this email directly, view it on GitHub
<#325 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMPSI4V7NG4WMZTDAMBQZDYCTUE7AVCNFSM6AAAAAA64NCR4KVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHA2TKOBUGI3DSNQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
hejllukas
approved these changes
Nov 14, 2023
|
But I don't have permission to approve pull requests. |
3dJan
requested review from
alexanderoster,
ewaldbr2 and
alexander-tobias-bockstaller
alexander-tobias-bockstaller
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using fast_float as suggest by @bubnikv to resolve the issue addressed by #322.
PR is already based on #324 to make the ci pass.