Setting c++17 for all compiler

3MFConsortium · Oct 20, 2023 · db040c8 · db040c8
1 parent ca32d26
commit db040c8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -34,6 +34,7 @@ option(USE_INCLUDED_SSL "Use included libressl" ON)
 option(BUILD_FOR_CODECOVERAGE "Build for code coverage analysis" OFF)
 
 add_compile_options($<$<CXX_COMPILER_ID:MSVC>:/MP>)
+set (CMAKE_CXX_STANDARD 17)
 
 if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
   # using GCC

diff --git a/Source/Common/NMR_StringUtils.cpp b/Source/Common/NMR_StringUtils.cpp
@@ -155,8 +155,6 @@ namespace NMR {
 		nfDouble dResult = 0.0;
 
 		// Convert to double and make a input and range check!
-		nfChar * pEndPtr;
-
 		std::from_chars_result result = std::from_chars(pszValue, pszValue + strlen(pszValue), dResult);
 
 		// Check if any conversion happened