Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: topK and topP not valid #642

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix: topK and topP not valid #642

merged 1 commit into from
Jul 29, 2024

Conversation

wenyangchou
Copy link
Contributor

The code is not valid

del_all(logits_warpers)
del_all(logits_processors)

for generate function is used yield as a return. As a result , generate has not been finished yet, and the wrapper has beed deleted.

@github-actions github-actions bot changed the base branch from main to dev July 29, 2024 09:12
@wenyangchou
Copy link
Contributor Author

When I deleted the code , there is a significant decrease in the number of bad cases .

Copy link
Member

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's a severe problem.

@fumiama fumiama enabled auto-merge (squash) July 29, 2024 16:57
@fumiama fumiama added bug Something isn't working algorithm Algorithm improvements & issues good first issue Good for newcomers labels Jul 29, 2024
@fumiama
Copy link
Member

fumiama commented Jul 29, 2024

ref #543

@fumiama fumiama merged commit 8f49418 into 2noise:dev Jul 29, 2024
5 checks passed
@AdamMayor2018
Copy link

这个解决不了出现unexpected end at index [0]和显存爆炸问题。

@fumiama
Copy link
Member

fumiama commented Aug 3, 2024

这个解决不了出现unexpected end at index [0]和显存爆炸问题。

unexpected end at index [0] 本身就和输入的内容和各项参数有关,但是这个错误大大加重了此问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Algorithm improvements & issues bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants