Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional sync finish condition check to fix infinite catchup status #447

Open
wants to merge 1 commit into
base: REL2_x_STABLE
Choose a base branch
from

Conversation

woonhak
Copy link

@woonhak woonhak commented Nov 22, 2023

If sync process synced very closely to the their remote,
there is a possibility that no commit since the starting LSN point.
If that is the case, apply worker is infinitely waiting for sync worker finished, but sync worker also is waiting for new commit to finish catching up state even if sync worker synced all of the log record from remote.
This randomly happened while running add_table test when alter_subscription_resynchronize_table() called and wait for complete sync.
To address that issue, we can evaluate sync finish condition while pulling log records.

…atus

 If sync process synced very closely to the their remote,
there is a possibility that no commit since the starting LSN point.
 If that is the case, sync/apply workers are infinitely waiting for new
commit to finish even if sync worker synced all of the log record from remote.
This randomly happened while running `add_table` test
when `alter_subscription_resynchronize_table()` called and wait for
complete sync called.
 To address that issue, we can evaluate sync finish condition while
 pulling log records.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant