Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Health check for Isley placed under devices section. #69

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

jackspiering
Copy link
Member

Pull Request Title: Fix: Health check for Isley placed under devices section.

Description

Fix: Health check for Isley placed under devices section.

Related Issues

  • N/A

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring

How Has This Been Tested?

Got the error: "Error response from daemon: error gathering device information while adding custom device "TS_ENABLE_HEALTH_CHECK=true": no such file or directory"

This is because the lines underneath were misplaced under device. I checked the full repo and this was the only compose file with this bug.

  - TS_ENABLE_HEALTH_CHECK=true              # Enable healthcheck endpoint: "/healthz"
  - TS_LOCAL_ADDR_PORT=127.0.0.1:41234       # The <addr>:<port> for the healthz endpoint

Docker compose up -d gives no
errors anymore.

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix or feature works
  • I have updated necessary documentation (e.g. frontpage README.md)
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

  • N/A

Additional Notes

  • N/A

@jackspiering jackspiering added the bug Something isn't working label Jan 9, 2025
@jackspiering jackspiering requested a review from crypt0rr January 9, 2025 21:11
@crypt0rr crypt0rr merged commit 6f059fd into main Jan 10, 2025
1 check passed
@crypt0rr crypt0rr deleted the 20250901-fixed-wrong-devices-variables branch January 10, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants