Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed ${SERVICE} to ${SERVICE}-data #62

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

jackspiering
Copy link
Member

Pull Request Title: [Short Description of Changes]

Description

Changed the variable ${SERVICE} to ${SERVICE}-data to make a more understandable folder structure.

Old situa

Related Issues

  • N/A

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring

How Has This Been Tested?

  • N/A

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix or feature works
  • I have updated necessary documentation (e.g. frontpage README.md)
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

  • N/A

Additional Notes

  • N/A

@jackspiering jackspiering requested a review from crypt0rr January 6, 2025 14:01
Copy link
Member

@crypt0rr crypt0rr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@crypt0rr crypt0rr merged commit f252cc6 into main Jan 6, 2025
1 check passed
@crypt0rr crypt0rr deleted the 20250601-datafolder branch January 6, 2025 14:03
@crypt0rr crypt0rr added the enhancement New feature or request label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants