Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing PATH issue for Serve #57

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Fixing PATH issue for Serve #57

merged 2 commits into from
Jan 5, 2025

Conversation

crypt0rr
Copy link
Member

@crypt0rr crypt0rr commented Jan 5, 2025 •
edited
Loading

Pull Request Title: Fixing PATH issue for Serve

Description

Fixes issue that is known under #56 - please refer to the issue for further explanation.

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring

How Has This Been Tested?

Testing is visible in the issue ticket #56.

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix or feature works
  • I have updated necessary documentation (e.g. frontpage README.md)
  • Any dependent changes have been merged and published in downstream modules

@crypt0rr crypt0rr added the bug Something isn't working label Jan 5, 2025
@crypt0rr crypt0rr requested a review from jackspiering January 5, 2025 19:13
@crypt0rr crypt0rr self-assigned this Jan 5, 2025
@crypt0rr crypt0rr mentioned this pull request Jan 5, 2025
Closed
2 tasks
jackspiering
jackspiering approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@jackspiering jackspiering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buggixerbert

@jackspiering jackspiering merged commit 8fb7b94 into main Jan 5, 2025
1 check passed
@jackspiering jackspiering deleted the 20250105-serve-config-path branch January 5, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackspiering jackspiering jackspiering approved these changes

Assignees

@crypt0rr crypt0rr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crypt0rr @jackspiering