Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS 17.1+ 에서 바텀시트가 제대로 표시되지 않는 문제 해결합니다. #3

Merged
merged 1 commit into from
Nov 6, 2023
Merged

iOS 17.1+ 에서 바텀시트가 제대로 표시되지 않는 문제 해결합니다. #3

merged 1 commit into from
Nov 6, 2023

Conversation

woojinjo-29cm
Copy link

배경

작업 내용

  • PanModalPresentionController 에서 화면 present 가 시작될 때 프레임이 0이면 다시 계산하도록 구성했습니다.

리뷰 노트

  • 이 부분 제가 이슈 확인할 때 브레이크 포인트 찍어서 프레임이 잘 잡히는 것으로 확인했었는데, 타이밍 관련된 문제가 조금 있었던 것 같습니다 ㅜ 간단한 방법이라 좋네요!

@woojinjo-29cm woojinjo-29cm added the 코드리뷰 - 옐로 오늘 안에 리뷰해주세요 label Nov 6, 2023
@woojinjo-29cm woojinjo-29cm requested a review from a team as a code owner November 6, 2023 05:35
@woojinjo-29cm woojinjo-29cm merged commit 03385fb into master Nov 6, 2023
@woojinjo-29cm woojinjo-29cm deleted the woopa01/pan-modal-frame-issue branch November 6, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyeongseokpark-29cm hyeongseokpark-29cm hyeongseokpark-29cm approved these changes

Assignees
No one assigned
Labels
코드리뷰 - 옐로 오늘 안에 리뷰해주세요
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woojinjo-29cm @hyeongseokpark-29cm @Woopa01