Skip to content

Commit

Permalink
fix(web): add margins in bug report and inquiry dialogs #2280 #2284
Browse files Browse the repository at this point in the history
Approved-by: Léon Dumestre <[email protected]>

Closes #2284

See merge request 24-heures-insa/overbookd-mono!3167
  • Loading branch information
polo-diemunsch authored and LeonDumestre committed Jan 6, 2025
1 parent 4814c8c commit 9ed0543
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const period = computed<IProvidePeriod>(() => ({
}));
const isPeriodInvalid = computed<boolean>(() => !Period.isValid(period.value));
const cantAddInquiry = computed<boolean>(
() => !gear.value && quantity.value <= 0,
() => !gear.value || quantity.value <= 0,
);
const cantInitInquiry = computed<boolean>(
() => cantAddInquiry.value || isPeriodInvalid.value,
Expand Down Expand Up @@ -66,3 +66,9 @@ const initInquiry = () => {
end.value = configurationStore.eventStartDate;
};
</script>

<style lang="css" scoped>
:deep(h3) {
margin-bottom: 5px;
}
</style>
19 changes: 13 additions & 6 deletions apps/web/components/molecules/help/BugReportDialogCard.vue
Original file line number Diff line number Diff line change
Expand Up @@ -16,25 +16,28 @@
</p>
<v-textarea
v-model="expectedBehaviour"
class="expected-behaviour-input"
class="textarea"
label="Comportement attendu"
no-resize
rows="4"
no-resize
hide-details
/>
<v-textarea
v-model="actualBehaviour"
class="actual-behaviour-input"
class="textarea"
label="Comportement constaté"
no-resize
rows="4"
no-resize
hide-details
/>
<v-textarea
v-model="stepsToReproduce"
class="steps-to-reproduce-input"
class="textarea"
label="Étapes pour reproduire"
:placeholder="stepsToReproducePlaceholder"
no-resize
rows="4"
no-resize
hide-details
/>
</template>
<template #actions>
Expand Down Expand Up @@ -91,6 +94,10 @@ const copyIssueTemplate = async () => {
</script>

<style lang="scss" scoped>
.textarea {
margin-top: 15px;
}
.actions {
display: flex;
gap: 10px;
Expand Down
2 changes: 1 addition & 1 deletion apps/web/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@overbookd/web",
"version": "3.3.72",
"version": "3.3.73",
"description": "Application web pour le logiciel de gestion du festival des 24 heures de l'INSA",
"author": "Club des 24 heures de l'INSA (https://www.24heures.org/)",
"homepage": "https://gitlab.com/24-heures-insa/overbookd-mono",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "overbookd",
"version": "3.23.1-rc.3",
"version": "3.23.1-rc.4",
"main": "index.js",
"keywords": [],
"license": "Apache-2.0",
Expand Down

0 comments on commit 9ed0543

Please sign in to comment.