pre-commit: set pass_filenames to true #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#258 added pre-commit support to Yamale, with `pass_filenames: false`, as only one path is supported at a time. #251 added support for multiple paths. Therefore now it is possible to use `pass_filenames: true` with pre-commit. Sample run (filenames redacted): ``` % pre-commit run --all-files yamale-schema-verify --verbose check yaml schema with Yamale............................................Passed - hook id: yamale-schema-verify - duration: 0.12s Validating file1.yaml... Validating file2.yaml... Validating file3.yaml... Validating file4.yaml... Validation success! 👍 [...] ```
|
Curious to hear if @rsrdesarrollo agrees before merging this. |
|
that's perfect thanks!! |
cblakkan
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#258 added pre-commit support to Yamale, with
pass_filenames: false, as only one path is supported at a time.#251 added support for multiple paths.
Therefore now it is possible to use
pass_filenames: truewith pre-commit.Sample run (filenames redacted):