Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#236 Hard fail on undefined includes #247

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

cblakkan
Copy link
Member

When an undefined include() is used inside any special validator that allows one of N types to be valid (e.g. map(), any()) -- no error is raised when the schema is valid despite the include being undefined and wrong.

@cblakkan cblakkan requested a review from joecackler April 24, 2024 19:48
@cblakkan cblakkan marked this pull request as ready for review April 24, 2024 21:45
@cblakkan cblakkan merged commit dc81fd6 into master Apr 24, 2024
6 checks passed
emmeowzing referenced this pull request in premiscale/premiscale Jun 3, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [yamale](https://togithub.com/23andMe/Yamale) | `^4.0.4` -> `^5.0.0` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/yamale/5.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/yamale/5.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/yamale/4.0.4/5.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/yamale/4.0.4/5.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [yamale](https://togithub.com/23andMe/Yamale) | `==4.0.4` -> `==5.2.1`
|
[![age](https://developer.mend.io/api/mc/badges/age/pypi/yamale/5.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/yamale/5.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/yamale/4.0.4/5.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/yamale/4.0.4/5.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>23andMe/Yamale (yamale)</summary>

### [`v5.2.1`](https://togithub.com/23andMe/Yamale/releases/tag/5.2.1)

[Compare
Source](https://togithub.com/23andMe/Yamale/compare/5.2.0...5.2.1)

##### What's Changed

- (fix)semver: SyntaxWarning: invalid escape sequence by
[@&#8203;kiblik](https://togithub.com/kiblik) in
[https://github.com/23andMe/Yamale/pull/248](https://togithub.com/23andMe/Yamale/pull/248)

##### New Contributors

- [@&#8203;kiblik](https://togithub.com/kiblik) made their first
contribution in
[https://github.com/23andMe/Yamale/pull/248](https://togithub.com/23andMe/Yamale/pull/248)

**Full Changelog**:
23andMe/Yamale@5.2.0...5.2.1

### [`v5.2.0`](https://togithub.com/23andMe/Yamale/releases/tag/5.2.0)

[Compare
Source](https://togithub.com/23andMe/Yamale/compare/5.1.0...5.2.0)

##### What's Changed

- Add CodeQL workflow for GitHub code scanning by
[@&#8203;lgtm-com](https://togithub.com/lgtm-com) in
[https://github.com/23andMe/Yamale/pull/205](https://togithub.com/23andMe/Yamale/pull/205)
- Add ruff gh action by
[@&#8203;cblakkan](https://togithub.com/cblakkan) in
[https://github.com/23andMe/Yamale/pull/244](https://togithub.com/23andMe/Yamale/pull/244)
- [#&#8203;236](https://togithub.com/23andMe/Yamale/issues/236) Hard
fail on undefined includes by
[@&#8203;cblakkan](https://togithub.com/cblakkan) in
[https://github.com/23andMe/Yamale/pull/247](https://togithub.com/23andMe/Yamale/pull/247)
- Add semantic versioning (semver.org) validator by
[@&#8203;thiagowfx](https://togithub.com/thiagowfx) in
[https://github.com/23andMe/Yamale/pull/246](https://togithub.com/23andMe/Yamale/pull/246)

##### New Contributors

- [@&#8203;lgtm-com](https://togithub.com/lgtm-com) made their first
contribution in
[https://github.com/23andMe/Yamale/pull/205](https://togithub.com/23andMe/Yamale/pull/205)
- [@&#8203;thiagowfx](https://togithub.com/thiagowfx) made their first
contribution in
[https://github.com/23andMe/Yamale/pull/246](https://togithub.com/23andMe/Yamale/pull/246)

**Full Changelog**:
23andMe/Yamale@5.1.0...5.2.0

### [`v5.1.0`](https://togithub.com/23andMe/Yamale/releases/tag/5.1.0)

[Compare
Source](https://togithub.com/23andMe/Yamale/compare/5.0.0...5.1.0)

##### What's Changed

- fix(cli): check schema to be a valid path first by
[@&#8203;AndreyNautilus](https://togithub.com/AndreyNautilus) in
[https://github.com/23andMe/Yamale/pull/241](https://togithub.com/23andMe/Yamale/pull/241)
- Ruff format codebase by
[@&#8203;cblakkan](https://togithub.com/cblakkan) in
[https://github.com/23andMe/Yamale/pull/243](https://togithub.com/23andMe/Yamale/pull/243)

##### New Contributors

- [@&#8203;AndreyNautilus](https://togithub.com/AndreyNautilus) made
their first contribution in
[https://github.com/23andMe/Yamale/pull/241](https://togithub.com/23andMe/Yamale/pull/241)

**Full Changelog**:
23andMe/Yamale@5.0.0...5.1.0

### [`v5.0.0`](https://togithub.com/23andMe/Yamale/releases/tag/5.0.0)

[Compare
Source](https://togithub.com/23andMe/Yamale/compare/4.0.4...5.0.0)

Supported python versions are now >= 3.8

##### What's Changed

- fix 3.12 deprecations by
[@&#8203;sigma67](https://togithub.com/sigma67) in
[https://github.com/23andMe/Yamale/pull/237](https://togithub.com/23andMe/Yamale/pull/237)
- Prep for 5.0.0; Run tests on 3.8, 3.12 by
[@&#8203;cblakkan](https://togithub.com/cblakkan) in
[https://github.com/23andMe/Yamale/pull/240](https://togithub.com/23andMe/Yamale/pull/240)

##### New Contributors

- [@&#8203;sigma67](https://togithub.com/sigma67) made their first
contribution in
[https://github.com/23andMe/Yamale/pull/237](https://togithub.com/23andMe/Yamale/pull/237)
- [@&#8203;cblakkan](https://togithub.com/cblakkan) made their first
contribution in
[https://github.com/23andMe/Yamale/pull/240](https://togithub.com/23andMe/Yamale/pull/240)

**Full Changelog**:
23andMe/Yamale@4.0.4...5.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [x] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/premiscale/premiscale).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants