Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-vectorized case w 21cmEMU #81

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DanielaBreitman
Copy link
Contributor

Fix error when setting vectorized = False in the MCMC options while using 21cmEMU.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.44%. Comparing base (a4e1484) to head (1d8d5a6).
Report is 1 commits behind head on master.

Files Patch % Lines
src/py21cmmc/core.py 66.66% 2 Missing ⚠️
src/py21cmmc/likelihood.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   73.53%   73.44%   -0.09%     
==========================================
  Files           8        8              
  Lines        2154     2158       +4     
==========================================
+ Hits         1584     1585       +1     
- Misses        570      573       +3     
Flag Coverage Δ
unittests 73.44% <50.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I just made one comment, but then it's fine

@@ -1329,9 +1326,13 @@ def build_model_data(self, ctx):
for t in zip(*values):
ap.append(dict(zip(keys, t)))
astro_params = np.array(ap, dtype=object)
if all(isinstance(v, (float, int)) for v in values) and len(values) > 0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be an elif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants