Rework _parse_route_data to allow multiple routing tables. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it is a bird2 feature, but not sure. I tried parsing a system with ipv6 enabled, which burned down because a line with 'Table: master6' suddenly appeared unexpedted. I guess this is a bird2 feature. I have reworked the _parse_route_data a bit more pythonic and to cope with this. I have introdcuced a dependancy, more_itertools. If that is undesired i'll go back to the drawingboard.
Heidistein
commented
Jan 2, 2024
pybird/__init__.py
Outdated
| routes = [] | ||
|
|
||
| route_summary = None | ||
| route_summar = None |
| @@ -19,6 +19,7 @@ packages = [{ include = "pybird" }] | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.7" | |||
| mote_itertools = "*" | |||
There was a problem hiding this comment.
Another small typo. I was testing your PR locally and PIP threw an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is a bird2 feature, but not sure. I tried parsing a system with ipv6 enabled, which burned down because a line with 'Table: master6' suddenly appeared unexpedted. I guess this is a bird2 feature. I have reworked the _parse_route_data a bit more pythonic and to cope with this.
I have introdcuced a dependancy, more_itertools. If that is undesired i'll go back to the drawingboard.