Feature/testplayer #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"chore: Class hierarchy change" |
integraldx
reviewed
Nov 13, 2024
|
"chore:review reflected" |
integraldx
reviewed
Nov 14, 2024
| @@ -52,7 +53,7 @@ private void Awake() | |||
| _collider = GetComponent<Collider>(); | |||
| _physicMaterial = _collider.material; | |||
| _isHoldingJump = false; | |||
| _isGrounded = 0; | |||
| _isGrounded = false; | |||
There was a problem hiding this comment.
IsGrounded 라는 프로퍼티로 만드는건 어떨까 싶습니다
integraldx
reviewed
Nov 14, 2024
| @@ -174,18 +160,23 @@ public void InteractWithProp(PropBase prop) | |||
|
|
|||
| private void OnCollisionEnter(Collision collision) | |||
| { | |||
|
|
|||
| var contactPoint = collision.contacts[0]; | |||
| if (contactPoint.normal.y > 0.7f) | |||
jihu0331
force-pushed
the
feature/testplayer
branch
from
f1325d8 to
956393e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Add: State transitions, Interactions with props"