[SC-1198] Upgrade FeeTaker #342
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zZoMROT
reviewed
Nov 21, 2024
zZoMROT
reviewed
Nov 21, 2024
zZoMROT
reviewed
Nov 21, 2024
| ) internal view virtual override returns (uint256) { | ||
| unchecked { | ||
| (, uint256 integratorFee, uint256 resolverFee, bytes calldata tail) = _parseFeeData(extraData, taker, _isWhitelistedGetterImpl); | ||
| return Math.mulDiv( |
There was a problem hiding this comment.
Is it correct to calculate makingAmount and then get fee from this amount? Should we at first get fee from takingAmount and then calculate makingAmount?
There was a problem hiding this comment.
Looks like incorrect in any case when order price is not 1:1, because we can get fee only in takerAsset
zZoMROT
reviewed
Nov 21, 2024
zZoMROT
reviewed
Nov 21, 2024
zZoMROT
reviewed
Nov 21, 2024
zZoMROT
approved these changes
Nov 26, 2024
byshape
reviewed
Nov 26, 2024
| * (bytes10)[N] — taker whitelist | ||
| */ | ||
| function getMakingAmount( | ||
| function postInteraction( |
There was a problem hiding this comment.
No docs for this function. It may be worth referring to them in the interface.
| * (bytes10)[N] — taker whitelist | ||
| */ | ||
| function getMakingAmount( | ||
| function postInteraction( |
There was a problem hiding this comment.
Suggested change
| function postInteraction( | |
| /** | |
| * @notice See {IPostInteraction-postInteraction}. | |
| */ | |
| function postInteraction( |
byshape
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FeeTakerchecks that taker is either in whitelist or hasAccessToken_parseFeeDatais universal for getters and postInteraction_isWhitelistedis virtual to allow for different whitelist structure in getters and postInteractionpostInteractionnow allows custom chained calls to other post-interactions