Skip to content

Commit

Permalink
Put back the Rails 5 tests
Browse files Browse the repository at this point in the history
  • Loading branch information
noelrappin committed Aug 22, 2023
1 parent 560a582 commit 4775606
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
- '3.1'
- '3.2'
rails:
- '5.1'
- '5.2'
- '6.0'
- '6.1'

Expand Down
9 changes: 9 additions & 0 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
appraise "rails-5.1" do
gem "rails", "~> 5.1.0"
end

appraise "rails-5.2" do
gem "rails", "~> 5.2.0"
end

appraise "rails-6.0" do
gem "rails", "~> 6.0.0"
end
Expand All @@ -6,6 +14,7 @@ appraise "rails-6.1" do
gem "rails", "~> 6.1.0"
end

# Rails 7.0 doesn't work yet
# appraise "rails-7.0" do
# gem "rails", "~> 7.0"
# end
3 changes: 3 additions & 0 deletions lib/active_record/connection_adapters/abstract_mysql.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# This module fails in Rails 7.0 becuase the method being modified has been
# changed to a class method.

module ActiveRecord
module ConnectionAdapters
class AbstractMysqlAdapter
Expand Down
4 changes: 2 additions & 2 deletions sql_enum.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ["lib"]

spec.add_dependency "activesupport", ">= 5.1"
spec.add_dependency "activerecord", ">= 5.1"
spec.add_dependency "activesupport", ">= 5.1", "< 7.0"
spec.add_dependency "activerecord", ">= 5.1", "< 7.0"
spec.add_dependency "mysql2"

spec.add_development_dependency "appraisal"
Expand Down

0 comments on commit 4775606

Please sign in to comment.