Return face bounding boxes along landmarks #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is True. This is backwards compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
These changes allow the user to also return the face bounding box, when calling
get_landmarks_from_imageorget_landmarks_from_batch, I think it doesn't break existent code and enables a second useful output.The option to enable this feature is passed as the last argument of
FaceAlignmentconstructor (return_face_results). By having it disabled by default, the return values of the twoget_landmarks_*remain as they currently are (only landmarks), therefore doesn't break existent code that expects single output. Also because of the default value in the constructor, it doesn't object creation with less or named arguments.