the cooler Date types PR #85
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not ready for merge, but I'm putting this out Draft, so you get CI run the tests. |
|
Hey, thanks for this! I had gotten sidetracked on other projects so I haven't looked at this branch in a while. |
2 tasks
LuminaSapphira
force-pushed
the
support-date-types-pk
branch
2 times, most recently
from
0c1edc4
to
ddc28c5
Compare
LuminaSapphira
force-pushed
the
support-date-types-pk
branch
from
ddc28c5
to
1b6d68b
Compare
LuminaSapphira
changed the title
snowsignal
suggested changes
Apr 11, 2023
core/src/language/typescript.rs
Outdated
| @@ -84,6 +92,15 @@ impl Language for TypeScript { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn end_file(&mut self, w: &mut dyn Write) -> std::io::Result<()> { | |||
| if self.has_date.load(Ordering::SeqCst) { | |||
| writeln!(w, "export function TypeshareDateReviver(key, value): Date {{ return new Date(value); }}")?; | |||
There was a problem hiding this comment.
What is the purpose for this function? Why does it need to take key?
There was a problem hiding this comment.
This is a provided function that can be passed to JSON.parse to revive JSON into an actual Date type rather than just an object. The function signature is necessary as it is what JSON.parse expects
|
Is there any work left to be done for this? Would be quite useful for many applications |
|
Awesome that there is an ongoing fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@CerulanLumina This is your
support-date-typesrebased onmain, with minor TypeScript and Kotlin extras. Use as you like.