-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation with service accounts #110
Update documentation with service accounts #110
Conversation
…rraform Provider As currently Provider supports both Connect and Service Accounts the name will be more general
Add debugging and commit signing instructions to CONTRIBUTING.md
…e-accounts' into update-documentation-with-service-accounts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review: ✅
The changes look good and straight forward. Thank you for making sure that the documentation is consistent.
I've left some non-blokcing comments, but once addressed we can merge this. 💪🏻
I've noticed the following in your PR description:
Improve
CONTRIBUTE.md
:
- Add Sign Your Commits section.
- Add Debugging section
Weren't these added as part of #109 already? If so, did we lose that data when merging #99? 🤔
@edif2008 thank you for the review. We just split the work between me and @williamhpark and prepared this branch with all the documentation changes for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a lot of comments and suggestions here, but please take them all with a grain of salt because I might be technically inaccurate. Additionally, keep in mind that I'll be starting issue #65 soon to add this documentation to the 1Password Developer Portal. After that, we'll need to have a discussion regarding whether we want to keep this information in the repo.
This PR updates documentation to mention Service Accounts support.
It also changes the term '1Password Connect Terraform Provider' to just '1Password Terraform Provider' to cover a wider scope of the tools that the Provider can work with (aka 1Password Connect and 1Password Service Accounts as per now).
Tasks:
Improve
CONTRIBUTE.md
:Resolves #106