Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix singaling not loading by ignoring token & update chart to match visual total support #457

Merged
merged 7 commits into from
Oct 9, 2024

Commits on Oct 7, 2024

  1. refactor: Update proposal type handling and chart logic.

    - Refactor proposal type handling and pool token enabling logic to include conditional checks based on the proposal type.
    - Updated the ConvictionBarChart component to remove redundant maximum value calculation and adjusted the y-axis maximum to improve chart clarity.
    - Made the poolToken property optional in the Props type definition.
    - The changes update the `poolToken` prop to be optional and modify a conditional rendering logic in the `ProposalCard` component.
    - Made the `poolToken` prop optional in the Proposals component's interface.
    - Updated the testnet version to 0.0.5 in the configuration.
    - Updated the `useHandleAllowance` function to allow `tokenAddr` to be undefined and adjusted the enabling condition accordingly.
    Corantin committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    1e1110d View commit details
    Browse the repository at this point in the history
  2. refactor: improve proposal type handling logic

    - Refactor the proposal type handling logic for improved clarity and correctness in the pool token fetching conditions.
    Corantin committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f4367a8 View commit details
    Browse the repository at this point in the history
  3. refactor: Improve convictionGrowth formatting logic.

    - Refactor the convictionGrowth computation to format the value more carefully by trimming unnecessary zeros and decimal points.
    Corantin committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    ed73b08 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Configuration menu
    Copy the full SHA
    440200e View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/dev' into fix-signaling-not-loading

    # Conflicts:
    #	apps/web/components/ProposalCard.tsx
    Corantin committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3c25231 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    534da57 View commit details
    Browse the repository at this point in the history
  4. refactor: streamline proposal handling and logic.

    - Refactor token fetching logic to conditionally exclude signaling type proposals while enhancing proposal data handling.
    - Modified the ProposalForm component to conditionally enable token fetching and loading spinner display based on the proposal type.
    - Refactor the ProposalCard component to streamline the handling of signaling type proposals and optimize the conviction reading logic.
    - Added proposalType parameter to conditionally enable the calculateThreshold function based on the PoolTypes.
    Corantin committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    b65ef0c View commit details
    Browse the repository at this point in the history