generated from BlossomLabs/web3-turbo-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowlist feature #439
Open
kamikazebr
wants to merge
51
commits into
dev
Choose a base branch
from
allowlist-feature
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Allowlist feature #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some strict equality vuln changed to <= or >= insteaad of ==
… into allowlist-feature
# Conflicts: # apps/web/configs/chains.tsx # pkg/contracts/out/CVStrategyHelpersV0_0.sol/CVStrategyHelpersV0_0.json # pkg/contracts/out/CVStrategyV0_0.sol/CVStrategyV0_0.json # pkg/contracts/out/CVStrategyV0_0.sol/IPointStrategy.json # pkg/contracts/out/CVStrategyV0_0.sol/StrategyStruct.json # pkg/contracts/out/PassportScorerTest.t.sol/PassportScorerTest.json # pkg/contracts/out/RegistryCommunityV0_0.sol/RegistryCommunityV0_0.json # pkg/contracts/out/RegistryFactoryV0_0.sol/RegistryFactoryV0_0.json # pkg/contracts/out/RegistryFactoryV0_1.sol/RegistryFactoryV0_1.json # pkg/contracts/out/SafeArbitratorTest.t.sol/SafeArbitratorTest.json # pkg/contracts/out/TERC20.sol/TERC20.json # pkg/contracts/out/UpgradeCVMultichain.s.sol/UpgradeCVMultichain.json # pkg/contracts/src/CVStrategy/CVStrategyV0_0.sol # pkg/contracts/src/RegistryCommunity/RegistryCommunityV0_0.sol # pkg/subgraph/subgraph.yaml
…ipts + errors between V0_0 and V0_1. Need to review before push
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Fixed tests, now pool is created from registryContract to keep implementation. Removed most createPool since we do it in setup and dont need to duplicate code
Added remove support allowed after being removed from allowlist, but only remove support and not add Added initialAllowList param to getParams() Forge fmt
# Conflicts: # pkg/contracts/out/Allo.sol/Allo.json # pkg/contracts/out/CVStrategyHelpers.sol/CVStrategyHelpers.json # pkg/contracts/out/CVStrategyV0_0.sol/CVStrategyV0_0.json # pkg/contracts/out/CVStrategyV0_0.sol/IPointStrategy.json # pkg/contracts/out/CVStrategyV0_1.sol/CVStrategyV0_1.json # pkg/contracts/out/ERC20.sol/ERC20.json # pkg/contracts/out/ERC20/IERC20.sol/IERC20.json # pkg/contracts/out/FAllo.sol/FAllo.json # pkg/contracts/out/GV2ERC20.sol/GV2ERC20.json # pkg/contracts/out/IAllo.sol/IAllo.json # pkg/contracts/out/IArbitrator.sol/IArbitrator.json # pkg/contracts/out/IERC20.sol/IERC20.json # pkg/contracts/out/IERC20Metadata.sol/IERC20Metadata.json # pkg/contracts/out/IERC20Permit.sol/IERC20Permit.json # pkg/contracts/out/IERC20Upgradeable.sol/IERC20Upgradeable.json # pkg/contracts/out/IRegistry.sol/IRegistry.json # pkg/contracts/out/IRegistryFactory.sol/IRegistryFactory.json # pkg/contracts/out/ISafe.sol/Enum.json # pkg/contracts/out/ISafe.sol/ISafe.json # pkg/contracts/out/ISafe.sol/SafeProxyFactory.json # pkg/contracts/out/MockERC20.sol/MockERC20.json # pkg/contracts/out/PassportScorer.sol/PassportScorer.json # pkg/contracts/out/PassportScorerTest.t.sol/PassportScorerTest.json # pkg/contracts/out/Registry.sol/Registry.json # pkg/contracts/out/RegistryCommunityV0_0.sol/RegistryCommunityV0_0.json # pkg/contracts/out/RegistryCommunityV0_1.sol/RegistryCommunityV0_1.json # pkg/contracts/out/RegistryFactoryDiamond.sol/RegistryFactoryDiamond.json # pkg/contracts/out/RegistryFactoryFacet.sol/RegistryFactoryFacet.json # pkg/contracts/out/RegistryFactoryV0_0.sol/RegistryFactoryV0_0.json # pkg/contracts/out/RegistryFactoryV0_1.sol/RegistryFactoryV0_1.json # pkg/contracts/out/RegistrySetup.sol/RegistrySetup.json # pkg/contracts/out/RegistrySetup.sol/RegistrySetupFull.json # pkg/contracts/out/SafeArbitrator.sol/SafeArbitrator.json # pkg/contracts/out/SafeArbitratorTest.t.sol/SafeArbitratorTest.json # pkg/contracts/out/SafeERC20.sol/SafeERC20.json # pkg/contracts/src/CVStrategy/CVStrategyV0_1.sol
Change precision for CVParams from 10 ** 7 to 10 ** 14 + fixed helpers accordingly + fixed tests and constants
This reverts commit cb001b1. # Conflicts: # pkg/contracts/out/Allo.sol/Allo.json # pkg/contracts/out/CVStrategyHelpers.sol/CVStrategyHelpers.json # pkg/contracts/out/CVStrategyV0_0.sol/CVStrategyV0_0.json # pkg/contracts/out/CVStrategyV0_0.sol/IPointStrategy.json # pkg/contracts/out/CVStrategyV0_1.sol/CVStrategyV0_1.json # pkg/contracts/out/ERC20.sol/ERC20.json # pkg/contracts/out/ERC20/IERC20.sol/IERC20.json # pkg/contracts/out/FAllo.sol/FAllo.json # pkg/contracts/out/GV2ERC20.sol/GV2ERC20.json # pkg/contracts/out/IAllo.sol/IAllo.json # pkg/contracts/out/IArbitrator.sol/IArbitrator.json # pkg/contracts/out/IERC20.sol/IERC20.json # pkg/contracts/out/IERC20Metadata.sol/IERC20Metadata.json # pkg/contracts/out/IERC20Permit.sol/IERC20Permit.json # pkg/contracts/out/IERC20Upgradeable.sol/IERC20Upgradeable.json # pkg/contracts/out/IRegistry.sol/IRegistry.json # pkg/contracts/out/IRegistryFactory.sol/IRegistryFactory.json # pkg/contracts/out/ISafe.sol/Enum.json # pkg/contracts/out/ISafe.sol/ISafe.json # pkg/contracts/out/ISafe.sol/SafeProxyFactory.json # pkg/contracts/out/MockERC20.sol/MockERC20.json # pkg/contracts/out/PassportScorer.sol/PassportScorer.json # pkg/contracts/out/PassportScorerTest.t.sol/PassportScorerTest.json # pkg/contracts/out/Registry.sol/Registry.json # pkg/contracts/out/RegistryCommunityV0_0.sol/RegistryCommunityV0_0.json # pkg/contracts/out/RegistryCommunityV0_1.sol/RegistryCommunityV0_1.json # pkg/contracts/out/RegistryFactoryDiamond.sol/RegistryFactoryDiamond.json # pkg/contracts/out/RegistryFactoryFacet.sol/RegistryFactoryFacet.json # pkg/contracts/out/RegistryFactoryV0_0.sol/RegistryFactoryV0_0.json # pkg/contracts/out/RegistryFactoryV0_1.sol/RegistryFactoryV0_1.json # pkg/contracts/out/RegistrySetup.sol/RegistrySetup.json # pkg/contracts/out/RegistrySetup.sol/RegistrySetupFull.json # pkg/contracts/out/SafeArbitrator.sol/SafeArbitrator.json # pkg/contracts/out/SafeArbitratorTest.t.sol/SafeArbitratorTest.json # pkg/contracts/out/SafeERC20.sol/SafeERC20.json # pkg/contracts/out/UpgradeCVMultichain.s.sol/UpgradeCVMultichain.json # pkg/contracts/src/CVStrategy/CVStrategyV0_0.sol
# Conflicts: # apps/web/configs/subgraph.json # pkg/contracts/out/CollateralVault.sol/CollateralVault.json # pkg/contracts/out/ICollateralVault.sol/ICollateralVault.json # pnpm-lock.yaml
…port, added tests
Forge fmt
Checked for loop gas vulnerability, added limit of 10000 after gas report, added tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.