Fix singaling not loading by ignoring token & update chart to match visual total support #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor proposal type handling and pool token enabling logic to include conditional checks based on the proposal type. - Updated the ConvictionBarChart component to remove redundant maximum value calculation and adjusted the y-axis maximum to improve chart clarity. - Made the poolToken property optional in the Props type definition. - The changes update the `poolToken` prop to be optional and modify a conditional rendering logic in the `ProposalCard` component. - Made the `poolToken` prop optional in the Proposals component's interface. - Updated the testnet version to 0.0.5 in the configuration. - Updated the `useHandleAllowance` function to allow `tokenAddr` to be undefined and adjusted the enabling condition accordingly.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Gemini Code Review encountered an error. Here is the step log: |
- Refactor the proposal type handling logic for improved clarity and correctness in the pool token fetching conditions.
- Refactor the convictionGrowth computation to format the value more carefully by trimming unnecessary zeros and decimal points.
# Conflicts: # apps/web/components/ProposalCard.tsx
- Refactor token fetching logic to conditionally exclude signaling type proposals while enhancing proposal data handling. - Modified the ProposalForm component to conditionally enable token fetching and loading spinner display based on the proposal type. - Refactor the ProposalCard component to streamline the handling of signaling type proposals and optimize the conviction reading logic. - Added proposalType parameter to conditionally enable the calculateThreshold function based on the PoolTypes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poolTokenprop to be optional and modify a conditional rendering logic in theProposalCardcomponent.poolTokenprop optional in the Proposals component's interface.useHandleAllowancefunction to allowtokenAddrto be undefined and adjusted the enabling condition accordingly.