Merge pull request #424 from 1Hive/fix-pool-form-conviction-growth-no…

…t-converted Bug: fix pool form conviction growth not converted to days
1Hive · Sep 21, 2024 · aae6deb · aae6deb
2 parents 55d3e76 + b2eed02
commit aae6deb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/apps/web/components/Forms/PoolEditForm.tsx b/apps/web/components/Forms/PoolEditForm.tsx
@@ -9,7 +9,6 @@ import { FormRadioButton } from "./FormRadioButton";
 import { FormSelect } from "./FormSelect";
 import { Button } from "../Button";
 import { EthAddress } from "../EthAddress";
-import { InfoBox } from "../InfoBox";
 import { chainConfigMap } from "@/configs/chains";
 import { usePubSubContext } from "@/contexts/pubsub.context";
 import { useChainFromPath } from "@/hooks/useChainFromPath";
@@ -55,7 +54,6 @@ export default function PoolEditForm({
  chainId,
  initValues,
  proposalType,
- proposalOnDispute: isProposalOnDispute,
  setModalOpen,
 }: Props) {
  const {
@@ -66,7 +64,7 @@ export default function PoolEditForm({
  defaultValues: {
  spendingLimit: initValues.spendingLimit,
  minimumConviction: initValues.minimumConviction,
- convictionGrowth: initValues.convictionGrowth,
+ convictionGrowth: Math.round(+initValues.convictionGrowth / 3600 / 24), // convert seconds to days
  minThresholdPoints: initValues.minThresholdPoints,
  // arb settings
  defaultResolution: initValues.defaultResolution,

diff --git a/apps/web/components/PoolHeader.tsx b/apps/web/components/PoolHeader.tsx
@@ -113,7 +113,7 @@ export default function PoolHeader({
  spendingLimitPct * MAX_RATIO_CONSTANT,
  );
 
- const convictionGrowth = calculateConvictionGrowthInSeconds(
+ const convictionGrowthSec = calculateConvictionGrowthInSeconds(
  strategy.config.decay,
  blockTime,
  );
@@ -133,7 +133,7 @@ export default function PoolHeader({
  (proposal) => ProposalStatus[proposal.proposalStatus] === "disputed",
  );
 
- const { value, unit } = convertSecondsToReadableTime(convictionGrowth);
+ const { value, unit } = convertSecondsToReadableTime(convictionGrowthSec);
 
  const poolConfig = [
  {
@@ -297,7 +297,7 @@ export default function PoolHeader({
  proposalOnDispute={proposalOnDispute}
  initValues={{
  minimumConviction: minimumConviction.toFixed(2),
- convictionGrowth: convictionGrowth.toFixed(2),
+ convictionGrowth: convictionGrowthSec.toFixed(2),
  minThresholdPoints: minThresholdPoints,
  spendingLimit: spendingLimit.toFixed(2),
  defaultResolution: defaultResolution,