Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch missing data #52

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Catch missing data #52

wants to merge 6 commits into from

Commits on Dec 10, 2020

  1. Update LTI_Assignments_Grades_Service.php 

    Take into account that $line_item['resourceId'] and $line_item['tag'] are optional
    @kpommerenke
    kpommerenke authored Dec 10, 2020
    Configuration menu
    Copy the full SHA
    830d960 View commit details
    Browse the repository at this point in the history

  2. Update LTI_Deep_Link.php 

    deep_link_settings['data'] might be empty. It is only required if  present in LtiDeepLinkingRequest message: https://www.imsglobal.org/spec/lti-dl/v2p0#data
    @kpommerenke
    kpommerenke authored Dec 10, 2020
    Configuration menu
    Copy the full SHA
    6c9466d View commit details
    Browse the repository at this point in the history

  3. Update LTI_OIDC_Login.php 

    Use $request['target_link_uri'] as the fall-back redirect_uri.
    @kpommerenke
    kpommerenke authored Dec 10, 2020
    Configuration menu
    Copy the full SHA
    b77df59 View commit details
    Browse the repository at this point in the history

  4. Update LTI_Message_Launch.php 

    Return new static instead of new LTI_Message_Launch so that the class can be extended.
Throw exception when nonce does not check out.
Remove var_dump() statement.
    @kpommerenke
    kpommerenke authored Dec 10, 2020
    Configuration menu
    Copy the full SHA
    d097113 View commit details
    Browse the repository at this point in the history

  5. Update LTI_Deep_Link_Resource.php 

    Return new static instead of new LTI_Deep_Link_Resource to make it easier to extend the class.
Include all line_item attributes in new deep link resource, not just scoreMaximum and label.
    @kpommerenke
    kpommerenke authored Dec 10, 2020
    Configuration menu
    Copy the full SHA
    48ac76c View commit details
    Browse the repository at this point in the history

  6. Update LTI_Lineitem.php 

    Offer default for missing $lineitem["startDateTime"] and $lineitem["endDateTime"].
Return new static instead of new LTI_Lineitem to make it easier to extend the class.
Decompose __toString() into two functions: to_array() and __toString()
    @kpommerenke
    kpommerenke authored Dec 10, 2020
    Configuration menu
    Copy the full SHA
    69bf3f7 View commit details
    Browse the repository at this point in the history