-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed Open Peeps to 18F Folks #722
base: main
Are you sure you want to change the base?
Conversation
…18F Folks. Peeps is the marshmallow.
@mitogi Is your intent to apply a change to the main branch and deploy it? Currently this PR is set to make a one-word change to the If so, if you click the Edit button at the top of the PR, you'll see a drop-down that will give you the option to change the base branch of the PR (that is, the branch that will receive the change you're proposing) to main. If you'd like to pair on making the change, let me know and I'd be happy to! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good – one minor spacing change, and a content change to consider.
content/brand/images.md
Outdated
@@ -11,7 +11,10 @@ eleventyNavigation: | |||
title: Images | |||
--- | |||
## Representing humans | |||
In order to offer more diverse and expressive ways to represent humans, we created a custom set of Open Peeps based on [the work of Pablo Stanley](https://www.openpeeps.com/). These are great for showing emotion and to represent anonymous user groups. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this extra space to match the remainder of the doc
content/brand/images.md
Outdated
@@ -11,7 +11,10 @@ eleventyNavigation: | |||
title: Images | |||
--- | |||
## Representing humans | |||
In order to offer more diverse and expressive ways to represent humans, we created a custom set of Open Peeps based on [the work of Pablo Stanley](https://www.openpeeps.com/). These are great for showing emotion and to represent anonymous user groups. | |||
|
|||
In order to represent a more diverse spectrum of human experiences, we’ve adopted an illustration style called *18F Folks*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we’ve adopted an illustration style called 18F Folks.
This line reads a little funny to me. I think 18F Folks refers to the customizable library, not necessarily the style. Much in the same way Open Peeps itself is called a library and not a style – even if it clearly uses a particular and consistent style. So my suggestion is something more like "We've created a library called "18F Folks, based on Pablo Stanley's..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good!
Changed Open Peeps to 18F Folks. Peeps is the trademarked marshmallow.
Changes proposed in this pull request:
security considerations
[Note the any security considerations here, or make note of why there are none]