This repository has been archived by the owner on Sep 9, 2019. It is now read-only.
Temporarily disable quarterly messages #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Clockwork config was modified so the code that automatically sends quarterly messages is commented out. Additionally, notices that quarterly messages are temporarily disabled were added to each quarterly message view and to the sidenav.
jmhooper
commented
Oct 12, 2016
| @@ -4,7 +4,6 @@ | |||
| background-color: #d0e9c6; | |||
| font-size: 0.8rem; | |||
| padding: 0.5em; | |||
| @include span-columns(10); | |||
There was a problem hiding this comment.
It looked to me like I'm safe to change the styles here. I did not see anywhere that the alert class was used in the markup.
There was a problem hiding this comment.
I think it is used automatically when we have a flash but could be wrong
There was a problem hiding this comment.
I had the same thought, and when I looked it seemed like those are rendered with the class flash-alert:
<div class="flashes">
<% user_facing_flashes.each do |key, value| -%>
<div class="flash-<%= key %>"><%= value %></div>
<% end -%>
</div>Ref:
The styles for that seems to live in app/assets/stylesheets/components/_flashes.scss.
|
Here's what the quarterly message views look like now:
|
|
LGTM! Thanks for doing this. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This temporarily disables quarterly messages to prevent confusion / miscommunication until we move forward on #234.