[pull] master from chjj:master #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This string will cause an error to be thrown when written: ^[[1;54r^[[H^[[11M^[[0;7m^O It breaks down to these calls: setScrollRegion([1, 54]); cursorPos([1, 1]); deleteLines([11]); charAttributes([0, 7]); setgLevel(0); // shift-in, 0x0f ^[[1;54r sets the scrollBottom to 54 which is bigger than the height of the terminal (25 in the original issue). This may be due to a mismatch between what the program thinks is the terminal height and what the terminal knows is its height. In other words, it's the programs fault. We can add a failsafe for this in multiple places.
term.js: Ignore application keypad mode for arrow keys
(approach borrowed from etherpad)
Fix issue with pty.js 0.2.7 having been removed from npm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )