-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/arm #92
base: develop
Are you sure you want to change the base?
Feature/arm #92
Conversation
To test this you would need to update the images value in wp-local-docker to ensure this image, where ever it lives, it used. I have a test version of this at https://hub.docker.com/repository/docker/dustinrue/wp-snapshots |
|
||
COPY --from=builder --chown=wpsnapshots=wpsnapshots /opt/wpsnapshots /opt/wpsnapshots | ||
RUN \ | ||
apt-get install mariadb-client -y && apt-get clean all && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not build until I added apt-get update
here. The mariadb-client package was not found.
apt-get install mariadb-client -y && apt-get clean all && \ | |
apt-get update && apt-get install mariadb-client -y && apt-get clean all && \ |
I was able to test this and it solves a couple of important problems.
This is the process I used to test.
This worked for me and I think this should be merged and deployed once the apt-get update part is added so it will build successfully. Until then, I'll be writing instructions for my team to update their local image to a working version. As a side note, might be a good idea to have multiple versions tagged for php version so that projects using php 8 and even php 8.1 can work correctly. This would require an update for 10up local docker so the php version of the project affects the version used to run snapshots. |
Description of the Change
This PR modifies the Dockerfile and build routines (actions) to:
Alternate Designs
Benefits
Full native speed for Apple M1
Possible Drawbacks
Verification Process
I'm unable to fully test this
Checklist:
Applicable Issues
Changelog Entry