-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix width and height metadata condition on svg_dimensions function #174
fix width and height metadata condition on svg_dimensions function #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good but I left a question inline about the tests and differences I am seeing locally.
@@ -262,6 +262,53 @@ public function test_one_pixel_fix() { | |||
), | |||
), | |||
), | |||
array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this what wp_get_attachment_metadata()
is expected to return following your changes in this and the other PR?
Using svgNoDimensions.svg
I don't get a sizes array stored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterwilsoncc I have updated this as per the actual response from the WP for the svgNoDimensions.svg
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description of the Change
Remediation work on the PR #154
Closes #
How to test the Change
Changelog Entry
Credits
Props @username, @username2, ...
Checklist: