fix width and height metadata condition on svg_dimensions function #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
sksaju
changed the title
jeffpaul
requested review from
peterwilsoncc
and removed request for
jeffpaul
| @@ -262,6 +262,53 @@ public function test_one_pixel_fix() { | |||
| ), | |||
| ), | |||
| ), | |||
| array( | |||
There was a problem hiding this comment.
Is this what wp_get_attachment_metadata() is expected to return following your changes in this and the other PR?
Using svgNoDimensions.svg I don't get a sizes array stored.
There was a problem hiding this comment.
@peterwilsoncc I have updated this as per the actual response from the WP for the svgNoDimensions.svg file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Remediation work on the PR #154
Closes #
How to test the Change
Changelog Entry
Credits
Props @username, @username2, ...
Checklist: