Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved UX with spacing & color options #135

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Improved UX with spacing & color options #135

merged 4 commits into from
Aug 1, 2023

Conversation

bmarshall511
Copy link
Contributor

@bmarshall511 bmarshall511 commented Jul 17, 2023 •
edited
Loading

Description of the Change

  1. Updated the name of the block to be clearer in what it provides
  2. Added spacing controls
  3. Added BG & text color controls
  4. Replaced the button to select media with the MediaPlaceholder component
  5. Updated the block icon

Closes #131

How to test the Change

  1. Update/create a post/page
  2. Add an Inline SVG block
  3. Use an SVG that has a fill of currentColor
  4. Select a text color to change the SVG fill
  5. Select a background color to change the background
  6. Test different alignments (left, center, right)

Changelog Entry

Added - Added Spacing & color controls & a more descriptive block name

Credits

Props @bmarshall511

Checklist:

@bmarshall511 bmarshall511 self-assigned this Jul 17, 2023
@bmarshall511 bmarshall511 mentioned this pull request Jul 17, 2023
Closed
@bmarshall511 bmarshall511 marked this pull request as ready for review July 18, 2023 11:42
@bmarshall511 bmarshall511 requested a review from a team as a code owner July 18, 2023 11:42
@bmarshall511 bmarshall511 requested review from iamdharmesh and removed request for a team July 18, 2023 11:42
iamdharmesh
iamdharmesh requested changes Jul 20, 2023
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the amazing work here @bmarshall511. The code looks good to me and it tests very well. Just added 2 minor notes to discuss otherwise, all is good here.

Thanks

includes/blocks/safe-svg/edit.js Outdated Show resolved Hide resolved
includes/blocks/safe-svg/register.php Outdated Show resolved Hide resolved
iamdharmesh
iamdharmesh approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @bmarshall511. It looks great now. 🚀

@iamdharmesh iamdharmesh added this to the 2.2.0 milestone Jul 25, 2023
@jeffpaul jeffpaul merged commit 0962c11 into develop Aug 1, 2023
11 checks passed
@jeffpaul jeffpaul deleted the feature/131-ux-improvements branch August 1, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdharmesh iamdharmesh iamdharmesh approved these changes

Assignees

@bmarshall511 bmarshall511

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Safe SVG Icon Block UX Suggestions
3 participants
@bmarshall511 @iamdharmesh @jeffpaul