Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make UI more consistent with core WP #263

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

psorensen
Copy link
Contributor

Description of the Change

This update moves makes the interface more consistent with the core UI by consistent padding to the toolbar button and popover element.

Before:

image

After:

image

Closes #231

How to test the Change

  • Add new paragraph text
  • Press cmd + o to toggle character inserter
  • Observe proper padding in both toolbar button and popover item

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Changed UI to have padding consistent with WP Core

Credits

@psorensen @fabiankaegy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions github-actions bot added this to the Future Release milestone Jul 22, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Jul 22, 2024
@psorensen psorensen mentioned this pull request Jul 23, 2024
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice little improvement and the code look good to me :)

I was unaware by how much of the UI is coming from the Library we are using here. That is a real bummer. But still this is a step in the right direction :)

@fabiankaegy fabiankaegy added the type:enhancement New feature or request. label Jul 23, 2024
@jeffpaul jeffpaul merged commit b2843aa into develop Aug 5, 2024
14 checks passed
@jeffpaul jeffpaul deleted the feature/update-ui branch August 5, 2024 16:34
@jeffpaul jeffpaul modified the milestones: Future Release, 1.2.0 Aug 5, 2024
@dkotter dkotter modified the milestones: 1.2.0, 1.1.3 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review. type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editorial UX Revamp
4 participants