-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Allow passing custom labels to MediaToolbar
component
#334
Conversation
Size Change: +76 B (+0.12%) Total Size: 63.5 kB
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this enhancement :)
Left one suggestion for how we can improve the solution. With that implemented this is ready to merge from my perspective :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good :)
1 failed test on run #901 ↗︎
Details:
cypress/e2e/IconPicker.spec.js • 1 failed test
Review all test suite changes for PR #334 ↗︎ |
MediaToolbar
component
The failing test is unrelated. |
🎉 A new testing version of this package has been published to NPM. You can install it with |
Description of the Change
Closes #242
How to test the Change
Changelog Entry
Added - Support for custom labels in
MediaToolbar
Fixed - Typo in documentation
Added - Custom media toolbar example
Credits
@Firestorm980
Checklist: