Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upkeep: add TS support for useTaxonomy hook #303

Merged
merged 11 commits into from
May 3, 2024
Merged

upkeep: add TS support for useTaxonomy hook #303

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ded2081
add TS support for `useTaxonomy` hook
Sidsector9 Mar 3, 2024
8997d66
try fix large package-lock.json
Sidsector9 Mar 11, 2024
1d2e1d2
Merge branch 'develop' into upkeep/hook-use-taxonomy
Sidsector9 Mar 11, 2024
329341e
add undefined type
Sidsector9 Mar 12, 2024
ca61275
Merge branch 'upkeep/hook-use-taxonomy' of github.com:10up/block-comp…
Sidsector9 Mar 12, 2024
1948237
improve return type
Sidsector9 Mar 12, 2024
6b2b3a4
Merge branch 'develop' into upkeep/hook-use-taxonomy
Sidsector9 Mar 12, 2024
66bb257
Merge branch 'develop' into upkeep/hook-use-taxonomy
Sidsector9 Apr 1, 2024
b330bfb
fix delete JS version of component
fabiankaegy Apr 16, 2024
5eed872
Merge branch 'develop' into upkeep/hook-use-taxonomy
fabiankaegy Apr 16, 2024
8eadb72
Merge branch 'develop' into upkeep/hook-use-taxonomy
fabiankaegy May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions hooks/use-taxonomy/index.js → hooks/use-taxonomy/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { useSelect } from '@wordpress/data';
import { store as coreStore } from '@wordpress/core-data';
import type { Taxonomy } from '@wordpress/core-data';

export function useTaxonomy(taxonomyName) {
export function useTaxonomy(taxonomyName: string) {
return useSelect(
(select) => {
const { getTaxonomy, hasFinishedResolution } = select(coreStore);
Expand All @@ -12,5 +13,5 @@ export function useTaxonomy(taxonomyName) {
return [taxonomy, hasResolvedTaxonomy];
},
[taxonomyName],
);
) as [ taxonomy: Taxonomy | undefined, hasResolvedTaxonomy: boolean ];
}
Loading