-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/234: Add Required
Component
#235
Conversation
Size Change: +2.19 kB (+4%) Total Size: 55.1 kB
|
40668bc
to
57f2510
Compare
Required
Component
@fabiankaegy I took a slightly different approach to show the error messages. (Video added in the PR description) I created a custom data store that keeps track of all the Blocks that uses the Wanted to check with you if you have a better approach before I continue with writing the tests. |
Required
ComponentRequired
Component
Hey @Sidsector9 👋 This is super cool :) Can you share a little more detail about why you decided to go with this approach? Was it because the other approach didn't work or because the messaging for users was unclear/confusing? Would love to better understand the constraints here :) |
Sure @fabiankaegy.
I was able to lock/unlock the post by providing unique IDs to a
I would love to hear if you have a better approach, somewhere I strongly believe you do 😄 |
@Sidsector9 Thank you again for working on this! It does exactly what I was looking and hoping for. I'm going to close this PR anyways for now, as @darrenjacoby came up with a really cool more powerful way to solve the same issue in #238 I still like the cleanliness of the |
I just saw @darrenjacoby's PR and I agree, it does a lot of other validations that this PR doesn't. Completely on board with the decision 👍 |
Description of the Change
Video
Screen-2023-07-02-223149.mp4
Closes #234
How to test the Change
Changelog Entry
Credits
Props @fabiankaegy @Sidsector9
Checklist: