Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed custom tweet message to make it work with scheduled posts. #267

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

iamdharmesh
Copy link
Member

Description of the Change

As reported in #263, Custom tweet messages don't remain persistent in posts. So, when we set a custom tweet message and schedule it for publish in the future, it just sends the generic tweet, but not the Tweet from custom tweet message. PR fixes this issue.

Closes #263

How to test the Change

  1. Create a post
  2. Set custom tweet message and save post as draft
  3. Refresh edit post page and verify that custom tweet message remain saved
  4. schedule post to be publish in future
  5. Verify that posted tweet is as per the custom tweet message when the scheduled post is scheduled.

Changelog Entry

Fixed - The custom tweet message does not work with scheduled posts.

Credits

Props @GeoffLambert77 @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh marked this pull request as ready for review August 15, 2023 09:54
@iamdharmesh iamdharmesh added this to the 2.2.0 milestone Aug 15, 2023
@github-actions github-actions bot added the needs:code-review This requires code review. label Aug 15, 2023
@iamdharmesh iamdharmesh modified the milestones: 2.2.0, 2.1.1 Aug 15, 2023
@iamdharmesh iamdharmesh mentioned this pull request Aug 15, 2023
16 tasks
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approving 👍

@iamdharmesh iamdharmesh merged commit 4413830 into develop Aug 17, 2023
13 of 16 checks passed
@iamdharmesh iamdharmesh deleted the fix/263 branch August 17, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not Tweet the Edited Tweet when "Scheduled"
2 participants