Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest C++ headers generated with nnvg 2.3.1 #265

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

Willmac16
Copy link
Contributor

I manually bumped the Nunavut version of the compiled types.

Is there any need/interest in automatically bumping the source with each new Nunavut release?

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd6a8b5) 83.22% compared to head (6925b51) 83.50%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   83.22%   83.50%   +0.28%     
==========================================
  Files           6        5       -1     
  Lines         739      473     -266     
==========================================
- Hits          615      395     -220     
+ Misses        124       78      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aentinger
Copy link
Member

Hi @Willmac16 ☕ 👋

Instead of manually editing all files you should run the pre-existing script to re-generate those DSDL files. Would you mind to update this PR? 😉

@Willmac16
Copy link
Contributor Author

Sorry, I wasn't very clear. I mean't manually running the update script vs some sort of automatic method of running the update script (e.g. a GitHub action that checks if the output of the transpile changes and creates a commit).

I was thinking an automatic solution might be nice given that the last bump to the nnvg version was 10 months ago with v2.0.9.

Additionally, I would be interested if there was a way the main CMakeLists could be modified to allow for exclusively externally supplied nunavut_suppport and pub reg types, without requiring a whole fork. That way external datatype users could use whatever version of Nunavut they want to/are forced to by dependencies.

@aentinger
Copy link
Member

Additionally, I would be interested if there was a way the main CMakeLists could be modified to allow for exclusively externally supplied nunavut_suppport and pub reg types, without requiring a whole fork. That way external datatype users could use whatever version of Nunavut they want to/are forced to by dependencies.

This should certainly be possible. I'm happy to review a PR what would provide such functionality.

I was thinking an automatic solution might be nice given that the last bump to the nnvg version was 10 months ago with v2.0.9.

Same. I'm open to any PR adding a custom action achieving exactly this.

Note: I've rebased on current main in order to let CI run its course.

Copy link
Member

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aentinger aentinger merged commit 5e43cc9 into 107-systems:main Jan 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants