Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang fails due to cbegin() returning an iterator, not a pointer, when casting to std::string_view #259

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Clang fails due to cbegin() returning an iterator, not a pointer, when casting to std::string_view #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/util/registry/Registry.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class Registry final : public cyphal::registry::Registry

TAccessResponse onAccess_1_0_Request_Received(TAccessRequest const &req)
{
auto const req_name = std::string_view(reinterpret_cast<const char *>(req.name.name.cbegin()),
auto const req_name = std::string_view(reinterpret_cast<const char *>(req.name.name.data()),
req.name.name.size());

/* Try to set the registers value. Note, if this is a RO register
Expand Down
4 changes: 2 additions & 2 deletions src/util/storage/register_storage.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ template <typename FeedWatchdogFunc>

// Find the next register in the registry.
const auto reg_name_storage = rgy.index(index); // This is a little suboptimal but we don't care.
const auto reg_name = std::string_view(reinterpret_cast<const char *>(reg_name_storage.name.cbegin()), reg_name_storage.name.size());
const auto reg_name = std::string_view(reinterpret_cast<const char *>(reg_name_storage.name.data()), reg_name_storage.name.size());
if (reg_name.empty())
{
break; // No more registers to load.
Expand Down Expand Up @@ -107,7 +107,7 @@ template <typename ResetPredicate, typename FeedWatchdogFunc>
feed_watchdog_func();

const auto reg_name_storage = rgy.index(index); // This is a little suboptimal but we don't care.
const auto reg_name = std::string_view(reinterpret_cast<const char *>(reg_name_storage.name.cbegin()), reg_name_storage.name.size());
const auto reg_name = std::string_view(reinterpret_cast<const char *>(reg_name_storage.name.data()), reg_name_storage.name.size());
if (reg_name.empty())
{
break; // No more registers to load.
Expand Down
Loading