[TECH] Suppression du script d'éligibilité V2 (PIX-15191). #10552
+0
−2,363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P-Jeremy
approved these changes
Nov 15, 2024
alexandrecoin
approved these changes
Nov 15, 2024
pix-service-auto-merge
force-pushed
the
pix-15191-remove-eligibility-v2-script
branch
from
458a456
to
5a75821
Compare
pix-service-auto-merge
force-pushed
the
pix-15191-remove-eligibility-v2-script
branch
from
5a75821
to
150c673
Compare
pix-service-auto-merge
deleted the
pix-15191-remove-eligibility-v2-script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
Lors de la PR de suppression du FT
FT_ENABLE_V3_ELIGIBILITY_CHECK#10468, on a constaté que le usecase d'éligibilité v2 était encore utilisé dans le script pour vérifier l'éligibilité v2.Or avec la généralisation de la v3, il n'est plus pertinent de le garder.
🌰 Proposition
Suppression du script + le usecase
🪵 Pour tester
Les tests passent