[FEATURE] Utiliser le composant Pix Toast dans Pix Certif (PIX-15280). #10542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
AndreiaPena
force-pushed
the
pix-15280-bump-pix-ui-to-48.2.0-on-pix-certif
branch
from
6da30cb
to
d5fbfa9
Compare
AndreiaPena
commented
Nov 14, 2024
| @@ -7,7 +7,6 @@ export default class UncompletedReportsInformationStep extends Component { | |||
| @tracked reportToEdit = null; | |||
| @tracked showAddIssueReportModal = false; | |||
| @tracked showIssueReportsModal = false; | |||
| @service notifications; | |||
There was a problem hiding this comment.
Service non utilisée sur ce composant
AndreiaPena
commented
Nov 14, 2024
| @@ -51,7 +50,6 @@ export default class EnrolledCandidates extends Component { | |||
|
|
|||
| @action | |||
| async deleteCertificationCandidate(certificationCandidate) { | |||
| this.notifications.clearAll(); | |||
There was a problem hiding this comment.
Le pixToast ne gère pas le clearAll.
A voir si on à réellement besoin de faire ça sur nos apps, dans ce cas on l'ajoutera dans une prochaine MAJ de ce composant.
AndreiaPena
force-pushed
the
pix-15280-bump-pix-ui-to-48.2.0-on-pix-certif
branch
7 times, most recently
from
fc638e1
to
f630aa1
Compare
AndreiaPena
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
AndreiaPena
changed the title
AndreiaPena
force-pushed
the
pix-15280-bump-pix-ui-to-48.2.0-on-pix-certif
branch
from
f630aa1
to
d7b110e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
Un nouveau composant de notification à été introduit dans la v
48.2.0de Pix UI.🌰 Proposition
Remplacer ember-cli-notifications par Pix Toast
🎃 Remarques
Un fix temporaire css est appliqué sur la couleur des icônes le temps que ce soit fait coté pix UI.
Lors de la prochaine montée de version, on le supprimera.
🪵 Pour tester