[BUGFIX] Réparer le usecase récupérant les étapes de présentation de parcours (PIX-15283). #10539
+35
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeyffrey
added
👀 Tech Review Needed
team-evaluation
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
Jeyffrey
force-pushed
the
pix-15283-fix-get-presentation-steps-check
branch
from
c04a1e3
to
f9a6b49
Compare
Libouk
reviewed
Nov 14, 2024
api/tests/prescription/campaign/unit/domain/usecases/get-presentation-steps_test.js
Outdated
Show resolved
Hide resolved
Libouk
approved these changes
Nov 14, 2024
Jeyffrey
force-pushed
the
pix-15283-fix-get-presentation-steps-check
branch
from
f9a6b49
to
a4c48f5
Compare
pix-service-auto-merge
force-pushed
the
pix-15283-fix-get-presentation-steps-check
branch
from
a4c48f5
to
f56980e
Compare
pix-service-auto-merge
deleted the
pix-15283-fix-get-presentation-steps-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
Une mauvaise méthode de repository a été utilisée dans le usecase récoltant les infos de début de parcours pour les nouvelles pages.
Cette méthode vérifie que l'utilisateur est membre d'une orga. Or, ce check n'est utile que dans PixOrga.
🌰 Proposition
Vérifier que l'utilisateur a bien une entrée active dans
campaign-participtionentre sonuserIdet la campagne en cours.🎃 Remarques
On avait émis l'idée d'un pré-handler...
Mais plus complexe à mettre en place avec un code campagne dans l'URL.
🪵 Pour tester
Tests verts