-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Corriger l'inscription en local sur la double mire SCO (PIX-15290) #10537
Merged
pix-service-auto-merge
merged 2 commits into
dev
from
pix-15290-fix-sco-authentication-pages
Nov 15, 2024
Merged
[BUGFIX] Corriger l'inscription en local sur la double mire SCO (PIX-15290) #10537
pix-service-auto-merge
merged 2 commits into
dev
from
pix-15290-fix-sco-authentication-pages
Nov 15, 2024
+20
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
bpetetot
reviewed
Nov 13, 2024
api/lib/infrastructure/serializers/jsonapi/sco-organization-learner-serializer.js
Outdated
Show resolved
Hide resolved
bpetetot
reviewed
Nov 13, 2024
api/lib/infrastructure/serializers/jsonapi/sco-organization-learner-serializer.js
Outdated
Show resolved
Hide resolved
er-lim
force-pushed
the
pix-15290-fix-sco-authentication-pages
branch
3 times, most recently
from
November 14, 2024 08:15
8acb6c3
to
8b14976
Compare
bpetetot
approved these changes
Nov 14, 2024
api/tests/unit/infrastructure/serializers/jsonapi/sco-organization-learner-serializer_test.js
Outdated
Show resolved
Hide resolved
api/tests/unit/infrastructure/serializers/jsonapi/sco-organization-learner-serializer_test.js
Outdated
Show resolved
Hide resolved
lego-technix
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Lu et testé fonctionnellement avec succès avec Firefox
er-lim
force-pushed
the
pix-15290-fix-sco-authentication-pages
branch
2 times, most recently
from
November 14, 2024 14:33
8842654
to
ea40ef0
Compare
er-lim
added
Tech Review OK
🚀 Ready to Merge
Func Review OK
PO validated functionally the PR
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
Nov 15, 2024
and token as id for serializeExternal method Co-authored-by: Emmanuelle Bonnemay <[email protected]>
when errors is not thrown from the API Co-authored-by: Emmanuelle Bonnemay <[email protected]>
pix-service-auto-merge
force-pushed
the
pix-15290-fix-sco-authentication-pages
branch
from
November 15, 2024 07:56
ea40ef0
to
374dc88
Compare
pix-service-auto-merge
deleted the
pix-15290-fix-sco-authentication-pages
branch
November 15, 2024 08:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
Lorsqu'on veut s'inscrire, en local, sur la double mire SCO, la route
/api/sco-organization-learners/possibilities
est appelée avec succès mais la suite du formulaire ne s'affiche pas.C'est causé par l'erreur Ember Data suivante :
🌰 Proposition
Ajouter, dans le serializer correspondant, un id avec comme valeur le username qui est unique pour ce cas.
🎃 Remarques
errorResponse.errors
dans la gestion des erreurs pour éviter une autre erreur lorsque que le champerrors
estundefined
.serializeExternal
pour éviter d'utiliser la fonctionrandomUUID
mais plutôt l'access token comme id 😄🪵 Pour tester (en local)
/campagnes/SCOBADGE1/presentation
.Je commence
.Je m'inscris
.