-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] API verifiant si un utilisateur a été candidat de certif (PIX-14984) #10533
Merged
pix-service-auto-merge
merged 3 commits into
dev
from
pix-14984-check-user-has-been-candidate
Nov 14, 2024
Merged
[FEATURE] API verifiant si un utilisateur a été candidat de certif (PIX-14984) #10533
pix-service-auto-merge
merged 3 commits into
dev
from
pix-14984-check-user-has-been-candidate
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
HEYGUL
reviewed
Nov 13, 2024
...certification/enrolment/integration/infrastructure/repositories/candidate-repository_test.js
Outdated
Show resolved
Hide resolved
HEYGUL
reviewed
Nov 13, 2024
...certification/enrolment/integration/infrastructure/repositories/candidate-repository_test.js
Show resolved
Hide resolved
P-Jeremy
reviewed
Nov 13, 2024
P-Jeremy
approved these changes
Nov 13, 2024
HEYGUL
approved these changes
Nov 13, 2024
bpetetot
force-pushed
the
pix-14984-check-user-has-been-candidate
branch
from
November 13, 2024 11:14
f786c06
to
647b16c
Compare
Steph0
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est propre ! 🤩
Steph0
reviewed
Nov 13, 2024
api/src/certification/enrolment/application/api/candidates-api.js
Outdated
Show resolved
Hide resolved
er-lim
reviewed
Nov 14, 2024
api/tests/certification/enrolment/unit/domain/usecases/has-been-candidate_test.js
Show resolved
Hide resolved
er-lim
reviewed
Nov 14, 2024
...certification/enrolment/integration/infrastructure/repositories/candidate-repository_test.js
Outdated
Show resolved
Hide resolved
er-lim
approved these changes
Nov 14, 2024
bpetetot
force-pushed
the
pix-14984-check-user-has-been-candidate
branch
from
November 14, 2024 13:30
647b16c
to
7b84015
Compare
pix-service-auto-merge
force-pushed
the
pix-14984-check-user-has-been-candidate
branch
3 times, most recently
from
November 14, 2024 14:33
d8ba982
to
34d9bdd
Compare
pix-service-auto-merge
force-pushed
the
pix-14984-check-user-has-been-candidate
branch
from
November 14, 2024 14:39
34d9bdd
to
5f9be3f
Compare
pix-service-auto-merge
deleted the
pix-14984-check-user-has-been-candidate
branch
November 14, 2024 14:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
Dans le cadre d'une nouvelle fonctionnalité permettant à un utilisateur de supprimer son compte lui-même (ie. anonymiser le compte), nous souhaitons restreindre la fonctionnalité aux utilisateurs qui n'ont jamais été candidat à une certification. (car l'anonymisation des données utilisateurs de certification n'est pas effective aujourd'hui)
🌰 Proposition
Depuis un contexte "Privacy" (lié à l'anonymisation), nous allons appelé une API du contexte
certification/enrolment
afin d'identifier si un utilisateur (viauserId
) a déjà été candidat à une certification.API Implementation
candidates-api.js
: Ajout dehasBeenCandidate
vérifiant si un utilisateur a été candidat via le use-case.Domain Use Case
has-been-candidate.js
: Ajout dehasBeenCandidate
vérifiant si au moins une candidature de l'utilisateur est réconciliée (isReconciled
) .Repository
candidate-repository.js
: AjoutfindByUserId
récupérant toutes les candidatures et ses subscriptions pour unuserId
spécifique.Exemple d'utilisation de l'api