Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Ne pas permettre de partager une campagne STARTED (PIX-15151) #10527

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

xav-car
Copy link
Contributor

@xav-car xav-car commented Nov 12, 2024

🍂 Problème

Suite à certains log erreur nous nous sommes rendu compte qu'il est possible de partagé une campagne non finit. Ce qui engendre des erreurs côté job asynchrone

🌰 Proposition

Être plus restrictif sur la qualification d'une campagne à partager ou à improved

🎃 Remarques

Mutualisation des loaders côté front pour les deux action retenter et partager. l'une ne pouvant fonctionner avec l'autre

🪵 Pour tester

Faire une participation avec la possibilité de retenter. Vérifier que l'on ne peut plus cliquer sur les deux boutons

@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@xav-car xav-car force-pushed the pix-15151/avoid-retry-shared branch 3 times, most recently from 8612272 to bfd023e Compare November 12, 2024 16:58
@xav-car xav-car marked this pull request as ready for review November 12, 2024 16:59
@xav-car xav-car requested a review from a team as a code owner November 12, 2024 16:59
@xav-car xav-car added the team-captains This is your captain speaking label Nov 12, 2024
@xav-car xav-car changed the title [BUGFIX] Ne pas permettre de partager une campagne STARTED (Pix-15151) [BUGFIX] Ne pas permettre de partager une campagne STARTED (PIX-15151) Nov 12, 2024
Copy link
Contributor

@alicegoarnisson alicegoarnisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Func OK / tech OK
Vu en mob

@pix-service-auto-merge pix-service-auto-merge merged commit 8f772d8 into dev Nov 14, 2024
8 of 9 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-15151/avoid-retry-shared branch November 14, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Func Review OK PO validated functionally the PR 🚀 Ready to Merge team-captains This is your captain speaking team-prescription
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants