-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Ne pas permettre de partager une campagne STARTED (PIX-15151) #10527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
xav-car
force-pushed
the
pix-15151/avoid-retry-shared
branch
3 times, most recently
from
November 12, 2024 16:58
8612272
to
bfd023e
Compare
xav-car
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
Nov 12, 2024
xav-car
changed the title
[BUGFIX] Ne pas permettre de partager une campagne STARTED (Pix-15151)
[BUGFIX] Ne pas permettre de partager une campagne STARTED (PIX-15151)
Nov 12, 2024
...sts/integration/components/campaigns/assessment/results/hero/evaluation-results-hero-test.js
Outdated
Show resolved
Hide resolved
...sts/integration/components/campaigns/assessment/results/hero/evaluation-results-hero-test.js
Show resolved
Hide resolved
xav-car
force-pushed
the
pix-15151/avoid-retry-shared
branch
from
November 14, 2024 15:24
bfd023e
to
6bb58f5
Compare
alicegoarnisson
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Func OK / tech OK
Vu en mob
alicegoarnisson
added
🚀 Ready to Merge
Func Review OK
PO validated functionally the PR
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
Nov 14, 2024
pix-service-auto-merge
force-pushed
the
pix-15151/avoid-retry-shared
branch
from
November 14, 2024 15:49
6bb58f5
to
1b4e532
Compare
pix-service-auto-merge
force-pushed
the
pix-15151/avoid-retry-shared
branch
from
November 14, 2024 15:49
1b4e532
to
0ece517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Func Review OK
PO validated functionally the PR
🚀 Ready to Merge
team-captains
This is your captain speaking
team-prescription
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
Suite à certains log erreur nous nous sommes rendu compte qu'il est possible de partagé une campagne non finit. Ce qui engendre des erreurs côté job asynchrone
🌰 Proposition
Être plus restrictif sur la qualification d'une campagne à partager ou à improved
🎃 Remarques
Mutualisation des loaders côté front pour les deux action retenter et partager. l'une ne pouvant fonctionner avec l'autre
🪵 Pour tester
Faire une participation avec la possibilité de retenter. Vérifier que l'on ne peut plus cliquer sur les deux boutons