tech(api): migrate route

1024pix · Nov 15, 2024 · 5677282 · 5677282
1 parent 9dd1bef
commit 5677282
Show file tree

Hide file tree

Showing 6 changed files with 87 additions and 146 deletions.
diff --git a/api/lib/application/users/index.js b/api/lib/application/users/index.js
@@ -192,31 +192,6 @@ const register = async function (server) {
         tags: ['api'],
       },
     },
-    {
-      method: 'GET',
-      path: '/api/users/{userId}/campaigns/{campaignId}/campaign-participations',
-      config: {
-        validate: {
-          params: Joi.object({
-            userId: identifiersType.userId,
-            campaignId: identifiersType.campaignId,
-          }),
-        },
-        pre: [
-          {
-            method: securityPreHandlers.checkRequestedUserIsAuthenticatedUser,
-            assign: 'requestedUserIsAuthenticatedUser',
-          },
-        ],
-        handler: userController.getUserCampaignParticipationToCampaign,
-        notes: [
-          '- **Cette route est restreinte aux utilisateurs authentifiés**\n' +
-            '- Récupération de la dernière participation d’un utilisateur (**userId**) à une campagne donnée (**campaignId**)\n' +
-            '- L’id demandé doit correspondre à celui de l’utilisateur authentifié',
-        ],
-        tags: ['api', 'user', 'campaign', 'campaign-participations'],
-      },
-    },
     {
       method: 'GET',
       path: '/api/users/{id}/trainings',

diff --git a/api/src/prescription/campaign-participation/application/campaign-participation-route.js b/api/src/prescription/campaign-participation/application/campaign-participation-route.js
@@ -258,6 +258,31 @@ const register = async function (server) {
         tags: ['api'],
       },
     },
+    {
+      method: 'GET',
+      path: '/api/users/{userId}/campaigns/{campaignId}/campaign-participations',
+      config: {
+        validate: {
+          params: Joi.object({
+            userId: identifiersType.userId,
+            campaignId: identifiersType.campaignId,
+          }),
+        },
+        pre: [
+          {
+            method: securityPreHandlers.checkRequestedUserIsAuthenticatedUser,
+            assign: 'requestedUserIsAuthenticatedUser',
+          },
+        ],
+        handler: campaignParticipationController.getUserCampaignParticipationToCampaign,
+        notes: [
+          '- **Cette route est restreinte aux utilisateurs authentifiés**\n' +
+            '- Récupération de la dernière participation d’un utilisateur (**userId**) à une campagne donnée (**campaignId**)\n' +
+            '- L’id demandé doit correspondre à celui de l’utilisateur authentifié',
+        ],
+        tags: ['api', 'user', 'campaign', 'campaign-participations'],
+      },
+    },
   ]);
 };
 

diff --git a/api/tests/acceptance/application/users/get-user-campaign-participation-to-campaign_test.js b/api/tests/acceptance/application/users/get-user-campaign-participation-to-campaign_test.js
diff --git a/...iption/campaign-participation/acceptance/application/campaign-participation-route_test.js b/...iption/campaign-participation/acceptance/application/campaign-participation-route_test.js
@@ -848,4 +848,32 @@ describe('Acceptance | API | Campaign Participations', function () {
       expect(participationIds).to.deep.equals([sharableCampaignParticipation.id, startedCampaignParticipation.id]);
     });
   });
+
+  describe('GET /users/{userId}/campaigns/{campaignId}/campaign-participations', function () {
+    let options;
+
+    beforeEach(function () {
+      databaseBuilder.factory.buildCampaignParticipation({
+        userId,
+        campaignId,
+        status: 'SHARED',
+      });
+
+      options = {
+        method: 'GET',
+        url: `/api/users/${userId}/campaigns/${campaignId}/campaign-participations`,
+        headers: { authorization: generateValidRequestAuthorizationHeader(userId) },
+      };
+
+      return databaseBuilder.commit();
+    });
+
+    it('should return campaign participation with 200 HTTP status code', async function () {
+      // when
+      const response = await server.inject(options);
+
+      // then
+      expect(response.statusCode).to.equal(200);
+    });
+  });
 });
diff --git a/...prescription/campaign-participation/unit/application/campaign-participation-route_test.js b/...prescription/campaign-participation/unit/application/campaign-participation-route_test.js
@@ -293,4 +293,38 @@ describe('Unit | Application | Router | campaign-participation-router ', functio
       expect(securityPreHandlers.checkAuthorizationToAccessCampaign.called).to.be.true;
     });
   });
+
+  describe('GET /api/users/{userId}/campaigns/{campaignId}/campaign-participations', function () {
+    const method = 'GET';
+
+    it('returns 400 when userId is not a number', async function () {
+      // given
+      const httpTestServer = new HttpTestServer();
+      await httpTestServer.register(moduleUnderTest);
+
+      const userId = 'wrongId';
+      const url = `/api/users/${userId}/campaigns/34/campaign-participations`;
+
+      // when
+      const result = await httpTestServer.request(method, url);
+
+      // then
+      expect(result.statusCode).to.equal(400);
+    });
+
+    it('returns 400 when campaignId is not a number', async function () {
+      // given
+      const httpTestServer = new HttpTestServer();
+      await httpTestServer.register(moduleUnderTest);
+
+      const campaignId = 'wrongId';
+      const url = `/api/users/12/campaigns/${campaignId}/campaign-participations`;
+
+      // when
+      const result = await httpTestServer.request(method, url);
+
+      // then
+      expect(result.statusCode).to.equal(400);
+    });
+  });
 });
diff --git a/api/tests/unit/application/users/index_test.js b/api/tests/unit/application/users/index_test.js
@@ -10,58 +10,6 @@ const CODE_IDENTITY_PROVIDER_POLE_EMPLOI = OidcIdentityProviders.POLE_EMPLOI.cod
 const oidcProviderCode = 'genericOidcProviderCode';
 
 describe('Unit | Router | user-router', function () {
-  describe('GET /api/users/{userId}/campaigns/{campaignId}/campaign-participations', function () {
-    const method = 'GET';
-
-    it('returns 200', async function () {
-      // given
-      sinon.stub(userController, 'getUserCampaignParticipationToCampaign').returns('ok');
-      sinon
-        .stub(securityPreHandlers, 'checkRequestedUserIsAuthenticatedUser')
-        .callsFake((request, h) => h.response(true));
-      const httpTestServer = new HttpTestServer();
-      await httpTestServer.register(moduleUnderTest);
-
-      const url = '/api/users/12/campaigns/34/campaign-participations';
-
-      // when
-      const result = await httpTestServer.request(method, url);
-
-      // then
-      expect(result.statusCode).to.equal(200);
-    });
-
-    it('returns 400 when userId is not a number', async function () {
-      // given
-      const httpTestServer = new HttpTestServer();
-      await httpTestServer.register(moduleUnderTest);
-
-      const userId = 'wrongId';
-      const url = `/api/users/${userId}/campaigns/34/campaign-participations`;
-
-      // when
-      const result = await httpTestServer.request(method, url);
-
-      // then
-      expect(result.statusCode).to.equal(400);
-    });
-
-    it('returns 400 when campaignId is not a number', async function () {
-      // given
-      const httpTestServer = new HttpTestServer();
-      await httpTestServer.register(moduleUnderTest);
-
-      const campaignId = 'wrongId';
-      const url = `/api/users/12/campaigns/${campaignId}/campaign-participations`;
-
-      // when
-      const result = await httpTestServer.request(method, url);
-
-      // then
-      expect(result.statusCode).to.equal(400);
-    });
-  });
-
   describe('GET /api/users/{id}/trainings', function () {
     const method = 'GET';