[BUGFIX] fixe la navigation #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xav-car
approved these changes
Nov 29, 2024
xav-car
added
Tech review OK
Func Review OK
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
|
Func tech ok : validé sur la PR orga-nav dans @10124pix/pix |
pix-service-auto-merge
pushed a commit
that referenced
this pull request
Nov 29, 2024
## [49.2.1](v49.2.0...v49.2.1) (2024-11-29) ### 🐛 Correction - [#775](#775) fixe la navigation
|
🎉 This PR is included in version 49.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Suite à l'intégration de la navigation dans les app, on s'est rendu compte que certain event handler de la nav (on-click-outside) bloqué le comportement de certains composant.
On souhaite aussi modifier la largeur de la navigation pour mieux s'adapter au langue
🎁 Proposition
Appliquer le
preventDefaultseulement lorsque les switcher de structure est ouvertAgrandir la nav a 15rem (240px)
🌟 Remarques
RAS
🎅 Pour tester
Tester le comportement des checkbox avec la nav en local