[FEATURE] Création du composant Table (PIX-14514) #771
+554
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fael-b
added
🚧 Development in progress
|
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr771.review.pix.fr |
Eithliu
force-pushed
the
pix-14514-create-pix-table-component
branch
from
6ec1535
to
e9836e0
Compare
fael-b
added
👀 Func Review Needed
👀 Tech Review Needed
and removed
🚧 Development in progress
|
Le composant se met à priori dans la catégorie Data display :) |
Co-authored-by: Iris Benoit <[email protected]> Co-authored-by: Fael Bassetti <[email protected]>
Co-authored-by: Jérémie Jadé <[email protected]> Co-authored-by: Fael Bassetti <[email protected]>
Co-authored-by: Jérémie Jadé <[email protected]> Co-authored-by: Fael Bassetti <[email protected]>
Co-authored-by: Jérémie Jadé <[email protected]> Co-authored-by: Fael Bassetti <[email protected]>
Eithliu
force-pushed
the
pix-14514-create-pix-table-component
branch
from
a01d6f2
to
9d03e36
Compare
xav-car
reviewed
Nov 27, 2024
| <table ...attributes> | ||
| <caption class="screen-reader-only">{{@caption}}</caption> | ||
| <thead> | ||
| <tr> |
There was a problem hiding this comment.
todo
Utiliser un named yield pour pousser les headers. Qui seront des futur <PixTableHeader>
Il pourront contenir autre chose que du texte.
xav-car
reviewed
Nov 27, 2024
xav-car
reviewed
Nov 27, 2024
| </thead> | ||
| <tbody> | ||
| {{#each this.computedData as |row|}} | ||
| <tr> |
There was a problem hiding this comment.
Idem pour le td. Ce sera des <PixTableCell> a ajouter dans un named yield
xav-car
reviewed
Nov 27, 2024
| @@ -1,12 +1,14 @@ | |||
| .pix-table { | |||
| width: 100%; | |||
| padding: var(--pix-spacing-4x); | |||
| overflow: auto; | |||
Co-authored-by: Jérémie Jadé <[email protected]> Co-authored-by: Fael Bassetti <[email protected]>
Jeremiejade
force-pushed
the
pix-14514-create-pix-table-component
branch
from
883491c
to
43186c1
Compare
Eithliu
force-pushed
the
pix-14514-create-pix-table-component
branch
from
75c5abd
to
00d275f
Compare
fael-b
force-pushed
the
pix-14514-create-pix-table-component
branch
from
00d275f
to
e151644
Compare
fael-b
force-pushed
the
pix-14514-create-pix-table-component
branch
from
e151644
to
43d6cd1
Compare
mcampourcy
reviewed
Nov 28, 2024
app/stories/pix-table-column.mdx
Outdated
|
|
||
| # PixTableColumn | ||
|
|
||
| TODO: insert component description |
There was a problem hiding this comment.
Pourquoi ne pas gérer les Todo maintenant ?
(oui, je veux vous faire bosser 😂)
|
Les tests func m'ont l'air OK jusqu'ici ! Et j'ai pouffé comme une gamine |
Eithliu
force-pushed
the
pix-14514-create-pix-table-component
branch
from
43d6cd1
to
37ba441
Compare
Co-authored-by: Iris Benoit-Martin <[email protected]> Co-authored-by: Jérémie Jadé <[email protected]> Co-authored-by: Fael Bassetti <[email protected]>
Eithliu
force-pushed
the
pix-14514-create-pix-table-component
branch
from
37ba441
to
49c3f10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Nous avons besoin d'un composant réutilisable table.
🎁 Proposition
Création du composant
PixTableet de son sous-composantPixTableColumnpour gérer le rendu des colonnes.🌟 Remarques
On utilise maintenant les block params d'Ember pour laisser l'utilisateur du composant gérer le rendu des colonnes.
🎅 Pour tester
Consulter sa documentation et nous faire des retours sur son apparence et son API si besoin.