[FEATURE] ajoute une declinaison de la navigation pour mobile (pix-15284) #770
+279
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr770.review.pix.fr |
lionelB
force-pushed
the
pix-15284/navbar-responsive-on-mobile
branch
4 times, most recently
from
2700193
to
77beb50
Compare
lionelB
force-pushed
the
pix-15284/navbar-responsive-on-mobile
branch
8 times, most recently
from
63765de
to
f042929
Compare
alicegoarnisson
force-pushed
the
pix-15284/navbar-responsive-on-mobile
branch
from
7a91a53
to
6cf695e
Compare
|
Changer le background du bouton "Menu" pour neutral-800 avec opacité |
xav-car
reviewed
Nov 27, 2024
addon/components/pix-navigation.hbs
Outdated
| aria-expanded={{this.navigationMenuOpened}} | ||
| @iconBefore={{if this.navigationMenuOpened "close" "menu"}} | ||
| @triggerAction={{this.toggleNavigationMenu}} | ||
| >Menu</PixButton> |
There was a problem hiding this comment.
todo il vaut mieux passer un argument pour le texte du bouton "Menu"
There was a problem hiding this comment.
later : utiliser le service isTablet/isDesktop pour cacher entierement cet élement lorsqu'il n'a pas d'interêt dans la page
xav-car
reviewed
Nov 27, 2024
xav-car
reviewed
Nov 27, 2024
xav-car
approved these changes
Nov 27, 2024
xav-car
added
Tech review OK
Func Review OK
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
alicegoarnisson
force-pushed
the
pix-15284/navbar-responsive-on-mobile
branch
2 times, most recently
from
a9cba5c
to
9470706
Compare
lionelB
force-pushed
the
pix-15284/navbar-responsive-on-mobile
branch
7 times, most recently
from
1e0600b
to
c25a6c7
Compare
lionelB
force-pushed
the
pix-15284/navbar-responsive-on-mobile
branch
from
c25a6c7
to
dc3d2a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
La nav est pas responsive
🎁 Proposition
Ajouter le responsive sur la nav
🌟 Remarques
On a été obliger de surcharger les styles inline rajouté par popper avec des
!important🎅 Pour tester
ouvrir la story de la pix-app-layout et redimensionner la page ou utiliser les outils responsive de storybook