[BREAKING] Renommer plusieurs composants Pix UI pour être iso avec le design system (PIX-14599). #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiaPena
added
👀 Design Review Needed
👀 Func Review Needed
👀 Tech Review Needed
cross-team
|
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr768.review.pix.fr |
er-lim
approved these changes
Nov 26, 2024
lionelB
reviewed
Nov 26, 2024
| @@ -26,7 +26,7 @@ const icons = { | |||
| [TYPE_COMMUNICATION_CERTIF]: 'campaign', | |||
| }; | |||
|
|
|||
| export default class PixBanner extends Component { | |||
| export default class PixBannerAlert extends Component { | |||
There was a problem hiding this comment.
question est ce qu'on conserve le nom des attributs @onCloseBannerTriggerAction et @canCloseBanner ?
There was a problem hiding this comment.
J'ai fait le choix de pas les modifier parce que ça reste une bannière, mais je peut modifier
AndreiaPena
added
🚀 Ready to Merge
and removed
👀 Design Review Needed
👀 Func Review Needed
👀 Tech Review Needed
labels
pix-service-auto-merge
force-pushed
the
pix-14599-rename-pix-ui-components
branch
from
e5a1851
to
f2c91db
Compare
pix-service-auto-merge
deleted the
pix-14599-rename-pix-ui-components
branch
pix-service-auto-merge
pushed a commit
that referenced
this pull request
Nov 27, 2024
# [49.0.0](v48.9.0...v49.0.0) (2024-11-27) ### 💥 BREAKING CHANGE - [#768](#768) Renommer plusieurs composants Pix UI pour être iso avec le design system (PIX-14599).
|
🎉 This PR is included in version 49.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 BREAKING_CHANGES
Plusieurs composants Pix UI ont été renommés :
PixProgressGaugedevientPixProgressBarPixMessagedevientPixNotificationAlertPixBannerdevientPixBannerAlertPixToggledevientPixToggleButtonPixCollapsibledevientPixAccordions🎄 Problème
Plusieurs composants existants sur Pix UI n'étaient pas alignés avec le nommage choisi dans le design system
🎁 Proposition
Les renommer
🌟 Remarques
Un bout de doc a été supprimé car plus pertinent.
🎅 Pour tester
Vérifier le comportement des composants suivants :
PixProgressBarPixNotificationAlertPixBannerAlertPixToggleButtonPixAccordions