Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Utiliser la dernière version mineure de NodeJs automatiquement #274

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

octo-topi
Copy link
Contributor

@octo-topi octo-topi commented Nov 9, 2022

💥 BREAKING_CHANGES

Pas d'impact UI

🎄 Problème

Il y a un équilibre à trouver entre:

  • déterminisme d'une version:
  • marge de tolérance (disponibilité de l'image docker, des packages managers OS).

🎁 Solution

Vérifier la version majeure de

  • node
  • npm

🌟 Remarques

PR bloquante pour le monorepo 1024pix/pix#5200

🎅 Pour tester

Vérifier que la CI passe, car elle vérifie les versions automatiquement

@pix-service
Copy link

I'm deploying this PR to:

Please check it out!

@VincentHardouin
Copy link
Member

De souvenir, il faut une certaine version de npm pour que ça fonctionne : #224

@octo-topi octo-topi changed the title [TECH] Vérifier la version majeure de NodeJS [TECH] Utiliser la dernière version mineure de NodeJs automatiquement Nov 15, 2022
@octo-topi octo-topi force-pushed the tech-check-node-major-version branch 2 times, most recently from 1bdd2eb to d98c7d5 Compare November 15, 2022 13:42
@octo-topi
Copy link
Contributor Author

De souvenir, il faut une certaine version de npm pour que ça fonctionne : #224

J'ai corrigé en mettant

"npm": ">=8.13.2 <9"

@github-actions github-actions bot force-pushed the tech-check-node-major-version branch from d98c7d5 to cc74a60 Compare December 2, 2022 08:48
@github-actions github-actions bot merged commit 16fd0c3 into dev Dec 2, 2022
@github-actions github-actions bot deleted the tech-check-node-major-version branch December 2, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants