Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy to S3 GitHub Action - #26 #33

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Add deploy to S3 GitHub Action - #26 #33

merged 2 commits into from
Aug 6, 2020

Conversation

what-name
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Not Applicable
  • Tests for the changes have been added (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #26

What is the new behavior?

The GitHub Action will build the Gatsby site and push it to the S3 bucket hosted on AWS.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Squash merge!!!

@what-name what-name merged commit 508d919 into 100DaysOfCloud:dev Aug 6, 2020
@rishabkumar7
Copy link
Member

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants